fix(forkJoin): accepts observables emitting null or undefined #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,18 @@ describe('Observable.forkJoin', function () { | |||
| var expected = '--------------(x|)'; | |||
|
|
|||
| expectObservable(e1).toBe(expected, {x: ['d', 'b', '3']}); | |||
|
|
|||
| //Hack - just adding one new test cases in here or either jasmin-is-weird-spec.js, | |||
There was a problem hiding this comment.
another weirdness of jasmine behavior, just separate this as test case makes another test fails. Placing under 'jasmine-is-weird' also doesn't work in this case.
|
I'll check this in around today, leaving bit more to see any other suggestions around. |
|
Merged with 6279d6b. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1362.
This PR updates behavior of forkJoin to check provided observable has emitted value by introducing explicit flag as same as RxJS 4 implementation to avoid emitting
nullorundefinedconsidered as observable does not contain any value.